linux-kernel - Re: [RFC PATCH hubcap] orangefs: orangefs_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6a125c70e81fd0daa1532410774b57b2dfdf409d.camel@perches.com>
Date:   Wed, 10 Apr 2019 19:15:02 -0700
From:   Joe Perches <joe@...ches.com>
To:     kbuild test robot <lkp@...el.com>,
        Mike Marshall <hubcap@...ibond.com>
Cc:     kbuild-all@...org, Martin Brandenburg <martin@...ibond.com>,
        devel@...ts.orangefs.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH hubcap] orangefs: orangefs_file_open() can be static

On Thu, 2019-04-11 at 09:58 +0800, kbuild test robot wrote:
> Fixes: 9a959aaffd70 ("orangefs: remember count when reading.")

Making something static likely does not warrant a "Fixes:" tag

> Signed-off-by: kbuild test robot <lkp@...el.com>
> ---
>  file.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/orangefs/file.c b/fs/orangefs/file.c
> index d198af9..01d0db6 100644
> --- a/fs/orangefs/file.c
> +++ b/fs/orangefs/file.c
> @@ -571,7 +571,7 @@ static int orangefs_lock(struct file *filp, int cmd, struct file_lock *fl)
>  	return rc;
>  }
>  
> -int orangefs_file_open(struct inode * inode, struct file *file)
> +static int orangefs_file_open(struct inode * inode, struct file *file)
>  {
>  	file->private_data = NULL;
>  	return generic_file_open(inode, file);