linux-kernel - Re: Some new bio merging behaviors in __bio_try_merge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190411153411.GA16987@infradead.org>
Date:   Thu, 11 Apr 2019 08:34:11 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Ming Lei <ming.lei@...hat.com>
Cc:     Gao Xiang <gaoxiang25@...wei.com>, linux-block@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        "linux-erofs@...ts.ozlabs.org" <linux-erofs@...ts.ozlabs.org>,
        Jens Axboe <axboe@...nel.dk>, Chao Yu <yuchao0@...wei.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: Some new bio merging behaviors in __bio_try_merge_page

On Thu, Apr 11, 2019 at 04:09:54PM +0800, Ming Lei wrote:
> I don't think it is a good behaviour to use bio->bi_max_vecs to limit
> max allowed page, you may see the idea from the naming simply...
> 
> If there were other such drivers, we may fix it easily, and the following
> patch should fix your issue:

Yep.  Consumers of the block layer really have no business at all
looking at bi_vcnt.