linux-kernel - Re: [PATCH-tip v3 00/14] locking/rwsem: Rwsem rearchitecture part 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf2ba2a2-b5ef-752a-6235-97df70a1b9eb@redhat.com>
Date:   Thu, 11 Apr 2019 12:09:07 -0400
From:   Waiman Long <longman@...hat.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Ingo Molnar <mingo@...hat.com>, Will Deacon <will.deacon@....com>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org, x86@...nel.org,
        Davidlohr Bueso <dave@...olabs.net>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Tim Chen <tim.c.chen@...ux.intel.com>,
        huang ying <huang.ying.caritas@...il.com>
Subject: Re: [PATCH-tip v3 00/14] locking/rwsem: Rwsem rearchitecture part 2

On 04/11/2019 04:37 AM, Peter Zijlstra wrote:
>
> After applying:
>
>  1,2,5,3
>
> Do we want to do something like the below?
>
> There is absolutely no reason anymore we need spread the implementation
> over 3 files: rwsem.h rwsem.c rwsem-xadd.c. And I went insane chasing
> things around.
>
> Note the below also includes a number of cleanups, there were still a
> bunch of EXPORT_SYMBOL()s and __visible crud from back when there was
> arch asm.
>
> And I also removed a bunch of pointless wrapper functions.
>
> I suspect there's more cleanups to be had, but for now this will do I
> suppose.
>
> ---
>  a/kernel/locking/rwsem-xadd.c |  608 ------------------------------
>  kernel/locking/Makefile       |    2 
>  kernel/locking/rwsem.c        |  831 ++++++++++++++++++++++++++++++++++++++++--
>  kernel/locking/rwsem.h        |  282 --------------
>  4 files changed, 813 insertions(+), 910 deletions(-)

I am OK with that. I am just so used to working with rwsem-xadd.c that
the idea of merging rwsem-xadd.c into rwsem.c didn't come to my mind. I
will include that in the next version.

Cheers,
Longman