linux-kernel - Re: [PATCH v8 02/11] dt-bindings: power: supply: add DT bindings for max77650

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqKHGczKAD3VjBsq6G=Ev0t8p_qWZ0YG6rRsqO8GuRAK7Q@mail.gmail.com>
Date:   Thu, 11 Apr 2019 11:50:19 -0500
From:   Rob Herring <robh@...nel.org>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Mark Rutland <mark.rutland@....com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Pavel Machek <pavel@....cz>, Lee Jones <lee.jones@...aro.org>,
        Sebastian Reichel <sre@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Input <linux-input@...r.kernel.org>,
        Linux LED Subsystem <linux-leds@...r.kernel.org>,
        Linux PM list <linux-pm@...r.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [PATCH v8 02/11] dt-bindings: power: supply: add DT bindings for max77650

On Tue, Apr 9, 2019 at 10:38 AM Bartosz Golaszewski <brgl@...ev.pl> wrote:
>
> wt., 9 kwi 2019 o 13:04 Bartosz Golaszewski <brgl@...ev.pl> napisał(a):
> >
> > wt., 9 kwi 2019 o 03:10 Rob Herring <robh@...nel.org> napisał(a):
> > >
> > > On Mon, Apr 8, 2019 at 7:25 AM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> > > >
> > > > sob., 6 kwi 2019 o 09:07 Rob Herring <robh@...nel.org> napisał(a):
> > > > >
> > > > > On Wed, Apr 03, 2019 at 11:00:59AM +0200, Bartosz Golaszewski wrote:
> > > > > > From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> > > > > >
> > > > > > Add the DT binding document for the battery charger module of max77650.
> > > > > >
> > > > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>
> > > > > > ---
> > > > > >  .../power/supply/max77650-charger.txt         | 27 +++++++++++++++++++
> > > > > >  1 file changed, 27 insertions(+)
> > > > > >  create mode 100644 Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> > > > > >
> > > > > > diff --git a/Documentation/devicetree/bindings/power/supply/max77650-charger.txt b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> > > > > > new file mode 100644
> > > > > > index 000000000000..fef188144386
> > > > > > --- /dev/null
> > > > > > +++ b/Documentation/devicetree/bindings/power/supply/max77650-charger.txt
> > > > > > @@ -0,0 +1,27 @@
> > > > > > +Battery charger driver for MAX77650 PMIC from Maxim Integrated.
> > > > > > +
> > > > > > +This module is part of the MAX77650 MFD device. For more details
> > > > > > +see Documentation/devicetree/bindings/mfd/max77650.txt.
> > > > > > +
> > > > > > +The charger is represented as a sub-node of the PMIC node on the device tree.
> > > > > > +
> > > > > > +Required properties:
> > > > > > +--------------------
> > > > > > +- compatible:                Must be "maxim,max77650-charger"
> > > > > > +
> > > > > > +Optional properties:
> > > > > > +--------------------
> > > > > > +- min-microvolt:     Minimum CHGIN regulation voltage (in microvolts). Must be
> > > > > > +                     one of: 4000000, 4100000, 4200000, 4300000, 4400000,
> > > > > > +                     4500000, 4600000, 4700000.
> > > > > > +- current-limit-microamp:    CHGIN input current limit (in microamps). Must
> > > > > > +                             be one of: 95000, 190000, 285000, 380000, 475000.
> > > > >
> > > > > To repeat what I said on v6, these should be common properties IMO (and
> > > > > therefore documented as such).
> > > > >
> > > >
> > > > Do you mean a separate "charger.txt" document in
> > > > Documentation/devicetree/bindings/power/supply/?
> > >
> > > Yes, though I thought we had something already.
> > >
> > > Rob
> >
> > We don't AFAICT. There's only a binding document for "simple-battery"
> > in power supply.
> >
> > Bart
>
> Can we have it locally for now but without the maxim prefix and then
> reuse it if any other charger needs such functionality? To make it
> even more generic we can name it: "input-voltage-min-microvolt" &
> "input-current-limit-microamp".

I guess. And defining these as 'input' is good because we do have
similar property names already for battery current limit and voltages.

Rob