lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <FF2E07CA-99D7-4F9C-B281-425897535C84@joshtriplett.org> Date: Wed, 10 Apr 2019 20:02:47 -0700 From: Josh Triplett <josh@...htriplett.org> To: Kees Cook <keescook@...omium.org> CC: Sinan Kaya <okaya@...nel.org>, LKML <linux-kernel@...r.kernel.org>, Masahiro Yamada <yamada.masahiro@...ionext.com>, Andrew Morton <akpm@...ux-foundation.org>, "Peter Zijlstra (Intel)" <peterz@...radead.org>, Johannes Weiner <hannes@...xchg.org>, Nicholas Piggin <npiggin@...il.com>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, Vasily Gorbik <gor@...ux.ibm.com>, Adrian Reber <adrian@...as.de>, Richard Guy Briggs <rgb@...hat.com>, Petr Mladek <pmladek@...e.com>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Matthew Wilcox <willy@...radead.org>, Joe Lawrence <joe.lawrence@...hat.com>, Randy Dunlap <rdunlap@...radead.org>, Mikulas Patocka <mpatocka@...hat.com>, Robin Murphy <robin.murphy@....com>, Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>, Changbin Du <changbin.du@...el.com>, Frederic Weisbecker <fweisbec@...il.com>, Sam Ravnborg <sam@...nborg.org>, Ingo Molnar <mingo@...nel.org> Subject: Re: [PATCH v2] init: Do not select DEBUG_KERNEL by default On April 10, 2019 4:24:18 PM PDT, Kees Cook <keescook@...omium.org> wrote: >On Wed, Apr 10, 2019 at 4:22 PM Josh Triplett <josh@...htriplett.org> >wrote: >> >> On April 10, 2019 3:58:55 PM PDT, Kees Cook <keescook@...omium.org> >wrote: >> >On Wed, Apr 10, 2019 at 3:42 PM Sinan Kaya <okaya@...nel.org> wrote: >> >> >> >> We can't seem to have a kernel with CONFIG_EXPERT set but >> >> CONFIG_DEBUG_KERNEL unset these days. >> >> >> >> While some of the features under the CONFIG_EXPERT require >> >> CONFIG_DEBUG_KERNEL, it doesn't apply for all features. >> >> >> >> It looks like CONFIG_KALLSYMS_ALL is the only feature that >> >> requires CONFIG_DEBUG_KERNEL. >> >> >> >> Select CONFIG_EXPERT when CONFIG_DEBUG is chosen but you can >> > >> >Typo: CONFIG_DEBUG_KERNEL >> > >> >> still choose CONFIG_EXPERT without CONFIG_DEBUG. >> > >> >same. >> > >> >> >> >> Signed-off-by: Sinan Kaya <okaya@...nel.org> >> > >> >But with those fixed, looks good to me. Adding Josh (and others) to >CC >> >since he originally added the linkage to EXPERT in commit >> >f505c553dbe2. >> >> CONFIG_DEBUG_KERNEL shouldn't affect code generation in any way; it >should only make more options appear in kconfig. I originally added >this to ensure that features you might want to *disable* aren't hidden, >as part of the tinification effort. >> >> What specific problem does having CONFIG_DEBUG_KERNEL enabled cause >for you? I'd still prefer to have a single switch for "don't hide >things I might want to disable", rather than several. > >See earlier in the thread: code generation depends on >CONFIG_DEBUG_KERNEL now unfortunately. Then let's fix *that*, and get checkpatch to help enforce it in the future. EXPERT doesn't affect code generation, and neither should this.
Powered by blists - more mailing lists