linux-kernel - Re: [PATCH 1/3] clocksource/drivers/timer-milbeaut: Fix to enable one-shot timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 12 Apr 2019 13:32:51 +0900
From:   "Sugaya, Taichi" <sugaya.taichi@...ionext.com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org
Cc:     Takao Orito <orito.takao@...ionext.com>,
        Kazuhiro Kasai <kasai.kazuhiro@...ionext.com>,
        Shinji Kanematsu <kanematsu.shinji@...ionext.com>,
        Jassi Brar <jaswinder.singh@...aro.org>,
        Masami Hiramatsu <masami.hiramatsu@...aro.org>
Subject: Re: [PATCH 1/3] clocksource/drivers/timer-milbeaut: Fix to enable
 one-shot timer

Hi,

Thank you for your comment.

On 2019/04/12 5:08, Daniel Lezcano wrote:
> On 25/03/2019 04:05, Sugaya Taichi wrote:
>> Fix mlb_set_oneshot_state() to enable one-shot timer.
>> The function should stop and start a timer, but "start" statement was
>> dropped. Kick the register to start one-shot timer.
> 
> Can you add the "Fixes" tag please.
> 
I got it, will resend with correct form.

Thanks,
Sugaya Taichi

> 
> 
>> Signed-off-by: Sugaya Taichi <sugaya.taichi@...ionext.com>
>> ---
>>   drivers/clocksource/timer-milbeaut.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/clocksource/timer-milbeaut.c b/drivers/clocksource/timer-milbeaut.c
>> index f2019a8..9fd5d08 100644
>> --- a/drivers/clocksource/timer-milbeaut.c
>> +++ b/drivers/clocksource/timer-milbeaut.c
>> @@ -80,6 +80,8 @@ static int mlb_set_state_oneshot(struct clock_event_device *clk)
>>   	u32 val = MLB_TMR_TMCSR_CSL_DIV2;
>>   
>>   	writel_relaxed(val, timer_of_base(to) + MLB_TMR_EVT_TMCSR_OFS);
>> +	val |= MLB_TMR_TMCSR_CNTE | MLB_TMR_TMCSR_TRG | MLB_TMR_TMCSR_INTE;
>> +	writel_relaxed(val, timer_of_base(to) + MLB_TMR_EVT_TMCSR_OFS);
>>   	return 0;
>>   }
>>   
>>
> 
>