linux-kernel - Re: [PATCH-tip v3 02/14] locking/rwsem: Make owner available even if !CONFIG_RWSEM_SPIN_ON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190412070904.GA45214@gmail.com>
Date:   Fri, 12 Apr 2019 09:09:04 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Waiman Long <longman@...hat.com>, Ingo Molnar <mingo@...hat.com>,
        Will Deacon <will.deacon@....com>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org, x86@...nel.org,
        Davidlohr Bueso <dave@...olabs.net>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Tim Chen <tim.c.chen@...ux.intel.com>,
        huang ying <huang.ying.caritas@...il.com>
Subject: Re: [PATCH-tip v3 02/14] locking/rwsem: Make owner available even if
 !CONFIG_RWSEM_SPIN_ON_OWNER


* Peter Zijlstra <peterz@...radead.org> wrote:

> On Fri, Apr 12, 2019 at 09:02:09AM +0200, Ingo Molnar wrote:
> > 
> > * Waiman Long <longman@...hat.com> wrote:
> > 
> > > On 04/11/2019 04:12 AM, Peter Zijlstra wrote:
> > > > On Wed, Apr 10, 2019 at 02:42:19PM -0400, Waiman Long wrote:
> > > >> The owner field in the rw_semaphore structure is used primarily for
> > > >> optimistic spinning. However, identifying the rwsem owner can also be
> > > >> helpful in debugging as well as tracing locking related issues when
> > > >> analyzing crash dump. The owner field may also store state information
> > > >> that can be important to the operation of the rwsem.
> > > >>
> > > >> So the owner field is now made a permanent member of the rw_semaphore
> > > >> structure irrespective of CONFIG_RWSEM_SPIN_ON_OWNER.
> > > > sem->owner is still initialized under CONFIG_RWSEM_SPIN_ON_OWNER.
> > > 
> > > Oh, you are right. I missed that part. I will fix it in the next version.
> > 
> > Could you please post the next series against tip:WIP.locking/core, which 
> > is already being dogfood-ed in -tip and which I'm running on my desktop? 
> > I'll backmerge any fixes as needed/requested.
> 
> Urgh, please no, that's going to be hell to review :/

Ok - full patches then. I'll handle the fallout.

Thanks,

	Ingo