linux-kernel - Re: [PATCH] platform/x86: pmc_atom: Drop _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 12 Apr 2019 09:15:39 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Stephen Boyd <sboyd@...nel.org>,
        Michael Turquette <mturquette@...libre.com>
Cc:     kbuild-all@...org, kbuild test robot <lkp@...el.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-clk@...r.kernel.org,
        David Müller <dave.mueller@....ch>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Subject: Re: [PATCH] platform/x86: pmc_atom: Drop __initconst on dmi table

Hi Stephen,

On 11-04-19 19:28, Stephen Boyd wrote:
> It's used by probe and that isn't an init function. Drop this so that we
> don't get a section mismatch.
> 
> Reported-by: kbuild test robot <lkp@...el.com>
> Cc: David Müller <dave.mueller@....ch>
> Cc: Hans de Goede <hdegoede@...hat.com>
> Cc: Andy Shevchenko <andy.shevchenko@...il.com>
> Fixes: 7c2e07130090 ("clk: x86: Add system specific quirk to mark clocks as critical")
> Signed-off-by: Stephen Boyd <sboyd@...nel.org>

Thank you for fixing this, I agree that this is the correct fix:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans


> ---
>   drivers/platform/x86/pmc_atom.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c
> index eaec2d306481..c7039f52ad51 100644
> --- a/drivers/platform/x86/pmc_atom.c
> +++ b/drivers/platform/x86/pmc_atom.c
> @@ -396,7 +396,7 @@ static int pmc_dbgfs_register(struct pmc_dev *pmc)
>    * Some systems need one or more of their pmc_plt_clks to be
>    * marked as critical.
>    */
> -static const struct dmi_system_id critclk_systems[] __initconst = {
> +static const struct dmi_system_id critclk_systems[] = {
>   	{
>   		.ident = "MPL CEC1x",
>   		.matches = {
>