linux-kernel - Re: [PATCH v1 3/3] ARM: dts: tegra30: Add External Memory Controller node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190412080158.GG12975@pdeschrijver-desktop.Nvidia.com>
Date:   Fri, 12 Apr 2019 11:01:58 +0300
From:   Peter De Schrijver <pdeschrijver@...dia.com>
To:     Dmitry Osipenko <digetx@...il.com>
CC:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Joseph Lo <josephl@...dia.com>, <devicetree@...r.kernel.org>,
        <linux-tegra@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 3/3] ARM: dts: tegra30: Add External Memory Controller
 node

On Fri, Apr 12, 2019 at 02:02:21AM +0300, Dmitry Osipenko wrote:
> Add Add External Memory Controller node to the device-tree.
> 

One 'Add' is enough I think :)

Peter.

> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
> ---
>  arch/arm/boot/dts/tegra30.dtsi     | 11 +++++++++++
>  drivers/memory/tegra/tegra30-emc.c |  3 ++-
>  2 files changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi
> index e074258d4518..92c4aeafab29 100644
> --- a/arch/arm/boot/dts/tegra30.dtsi
> +++ b/arch/arm/boot/dts/tegra30.dtsi
> @@ -732,6 +732,17 @@
>  		#reset-cells = <1>;
>  	};
>  
> +	memory-controller@...0f400 {
> +		compatible = "nvidia,tegra30-emc";
> +		reg = <0x7000f400 0x400>;
> +		interrupts = <GIC_SPI 78 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&tegra_car TEGRA30_CLK_EMC>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		nvidia,memory-controller = <&mc>;
> +	};
> +
>  	fuse@...0f800 {
>  		compatible = "nvidia,tegra30-efuse";
>  		reg = <0x7000f800 0x400>;
> diff --git a/drivers/memory/tegra/tegra30-emc.c b/drivers/memory/tegra/tegra30-emc.c
> index 38ebdb076ccd..defdb38bde54 100644
> --- a/drivers/memory/tegra/tegra30-emc.c
> +++ b/drivers/memory/tegra/tegra30-emc.c
> @@ -980,7 +980,8 @@ static long emc_round_rate(unsigned long rate,
>  	}
>  
>  	if (!timing) {
> -		dev_err(emc->dev, "no timing for rate %lu\n", rate);
> +		dev_err(emc->dev, "no timing for rate %lu min %lu max %lu\n",
> +			rate, min_rate, max_rate);
>  		return -EINVAL;
>  	}
>  
> -- 
> 2.21.0
>