lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <a63e7320-25a7-4516-9e9e-0fbdcee6f528@rwthex-w2-a.rwth-ad.de> Date: Fri, 12 Apr 2019 03:13:00 +0200 From: Stefan Brüns <stefan.bruens@...h-aachen.de> To: <linux-media@...r.kernel.org> CC: <linux-kernel@...r.kernel.org>, Mauro Carvalho Chehab <mchehab@...nel.org>, Antti Palosaari <crope@....fi>, Stefan Brüns <stefan.bruens@...h-aachen.de> Subject: [PATCH 3/3] media: af9035: Remove duplicate error reporting for dvbsky_usb_generic_rw All error cases inside the function already report errors via dev_err(), and dvb_usb_v2_generic_rw also reports all error cases, so there is no silent code path when an error has occured. Signed-off-by: Stefan Brüns <stefan.bruens@...h-aachen.de> --- drivers/media/usb/dvb-usb-v2/af9035.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/af9035.c b/drivers/media/usb/dvb-usb-v2/af9035.c index 80d3bd3a0f24..920596f78460 100644 --- a/drivers/media/usb/dvb-usb-v2/af9035.c +++ b/drivers/media/usb/dvb-usb-v2/af9035.c @@ -120,8 +120,6 @@ static int af9035_ctrl_msg(struct dvb_usb_device *d, struct usb_req *req) memcpy(req->rbuf, &state->buf[ACK_HDR_LEN], req->rlen); exit: mutex_unlock(&d->usb_mutex); - if (ret < 0) - dev_dbg(&intf->dev, "failed=%d\n", ret); return ret; } -- 2.21.0
Powered by blists - more mailing lists