lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Fri, 12 Apr 2019 12:13:02 +0200
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Arve Hjønnevåg <arve@...roid.com>,
        Todd Kjos <tkjos@...roid.com>,
        Martijn Coenen <maco@...roid.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        Christian Brauner <christian@...uner.io>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Adham Abozaeid <adham.abozaeid@...rochip.com>,
        Ajay Singh <ajay.kathat@...rochip.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        linux-media@...r.kernel.org, linux-wireless@...r.kernel.org
Subject: [PATCH] staging: remove redundant 'default n' from Kconfig

'default n' is the default value for any bool or tristate Kconfig
setting so there is no need to write it explicitly.

Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO
is not set' for visible symbols") the Kconfig behavior is the same
regardless of 'default n' being present or not:

    ...
    One side effect of (and the main motivation for) this change is making
    the following two definitions behave exactly the same:
    
        config FOO
                bool
    
        config FOO
                bool
                default n
    
    With this change, neither of these will generate a
    '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied).
    That might make it clearer to people that a bare 'default n' is
    redundant.
    ...

Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
---
 drivers/staging/Kconfig                    |    1 -
 drivers/staging/android/Kconfig            |    2 --
 drivers/staging/axis-fifo/Kconfig          |    1 -
 drivers/staging/gs_fpgaboot/Kconfig        |    1 -
 drivers/staging/media/Kconfig              |    1 -
 drivers/staging/media/rockchip/vpu/Kconfig |    1 -
 drivers/staging/most/Kconfig               |    1 -
 drivers/staging/rtl8192e/Kconfig           |    1 -
 drivers/staging/wilc1000/Kconfig           |    1 -
 drivers/staging/wlan-ng/Kconfig            |    1 -
 10 files changed, 11 deletions(-)

Index: b/drivers/staging/Kconfig
===================================================================
--- a/drivers/staging/Kconfig	2019-04-12 12:04:20.794128367 +0200
+++ b/drivers/staging/Kconfig	2019-04-12 12:04:20.786128367 +0200
@@ -1,7 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0
 menuconfig STAGING
 	bool "Staging drivers"
-	default n
 	---help---
 	  This option allows you to select a number of drivers that are
 	  not of the "normal" Linux kernel quality level.  These drivers
Index: b/drivers/staging/android/Kconfig
===================================================================
--- a/drivers/staging/android/Kconfig	2019-04-12 12:04:20.794128367 +0200
+++ b/drivers/staging/android/Kconfig	2019-04-12 12:04:20.786128367 +0200
@@ -5,7 +5,6 @@ if ANDROID
 
 config ASHMEM
 	bool "Enable the Anonymous Shared Memory Subsystem"
-	default n
 	depends on SHMEM
 	help
 	  The ashmem subsystem is a new shared memory allocator, similar to
@@ -17,7 +16,6 @@ config ASHMEM
 
 config ANDROID_VSOC
 	tristate "Android Virtual SoC support"
-	default n
 	depends on PCI_MSI
 	help
 	  This option adds support for the Virtual SoC driver needed to boot
Index: b/drivers/staging/axis-fifo/Kconfig
===================================================================
--- a/drivers/staging/axis-fifo/Kconfig	2019-04-12 12:04:20.794128367 +0200
+++ b/drivers/staging/axis-fifo/Kconfig	2019-04-12 12:04:59.734129348 +0200
@@ -5,7 +5,6 @@
 config XIL_AXIS_FIFO
 	tristate "Xilinx AXI-Stream FIFO IP core driver"
 	depends on OF
-	default n
 	help
 	  This adds support for the Xilinx AXI-Stream
 	  FIFO IP core driver.
Index: b/drivers/staging/gs_fpgaboot/Kconfig
===================================================================
--- a/drivers/staging/gs_fpgaboot/Kconfig	2019-04-12 12:04:20.794128367 +0200
+++ b/drivers/staging/gs_fpgaboot/Kconfig	2019-04-12 12:04:20.790128367 +0200
@@ -4,6 +4,5 @@
 #
 config GS_FPGABOOT
 	tristate "Xilinx FPGA firmware download module"
-	default n
 	help
 	  Xilinx FPGA firmware download module
Index: b/drivers/staging/media/Kconfig
===================================================================
--- a/drivers/staging/media/Kconfig	2019-04-12 12:04:20.794128367 +0200
+++ b/drivers/staging/media/Kconfig	2019-04-12 12:05:05.470129493 +0200
@@ -1,7 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0
 menuconfig STAGING_MEDIA
 	bool "Media staging drivers"
-	default n
 	help
 	  This option allows you to select a number of media drivers that
 	  don't have the "normal" Linux kernel quality level.
Index: b/drivers/staging/media/rockchip/vpu/Kconfig
===================================================================
--- a/drivers/staging/media/rockchip/vpu/Kconfig	2019-04-12 12:04:20.794128367 +0200
+++ b/drivers/staging/media/rockchip/vpu/Kconfig	2019-04-12 12:04:20.794128367 +0200
@@ -6,7 +6,6 @@ config VIDEO_ROCKCHIP_VPU
 	select VIDEOBUF2_DMA_CONTIG
 	select VIDEOBUF2_VMALLOC
 	select V4L2_MEM2MEM_DEV
-	default n
 	help
 	  Support for the Video Processing Unit present on Rockchip SoC,
 	  which accelerates video and image encoding and decoding.
Index: b/drivers/staging/most/Kconfig
===================================================================
--- a/drivers/staging/most/Kconfig	2019-04-12 12:04:20.794128367 +0200
+++ b/drivers/staging/most/Kconfig	2019-04-12 12:04:20.794128367 +0200
@@ -2,7 +2,6 @@
 menuconfig MOST
         tristate "MOST support"
 	depends on HAS_DMA
-        default n
         ---help---
 	  Say Y here if you want to enable MOST support.
 	  This driver needs at least one additional component to enable the
Index: b/drivers/staging/rtl8192e/Kconfig
===================================================================
--- a/drivers/staging/rtl8192e/Kconfig	2019-04-12 12:04:20.794128367 +0200
+++ b/drivers/staging/rtl8192e/Kconfig	2019-04-12 12:04:20.794128367 +0200
@@ -2,7 +2,6 @@
 config RTLLIB
 	tristate "Support for rtllib wireless devices"
 	depends on WLAN && m
-	default n
 	select LIB80211
 	help
 	  If you have a wireless card that uses rtllib, say
Index: b/drivers/staging/wilc1000/Kconfig
===================================================================
--- a/drivers/staging/wilc1000/Kconfig	2019-04-12 12:04:20.794128367 +0200
+++ b/drivers/staging/wilc1000/Kconfig	2019-04-12 12:04:20.794128367 +0200
@@ -34,7 +34,6 @@ config WILC1000_SPI
 config WILC1000_HW_OOB_INTR
 	bool "WILC1000 out of band interrupt"
 	depends on WILC1000_SDIO
-	default n
 	help
 	  This option enables out-of-band interrupt support for the WILC1000
 	  chipset. This OOB interrupt is intended to provide a faster interrupt
Index: b/drivers/staging/wlan-ng/Kconfig
===================================================================
--- a/drivers/staging/wlan-ng/Kconfig	2019-04-12 12:04:20.794128367 +0200
+++ b/drivers/staging/wlan-ng/Kconfig	2019-04-12 12:04:20.794128367 +0200
@@ -4,7 +4,6 @@ config PRISM2_USB
 	depends on WLAN && USB && CFG80211
 	select WIRELESS_EXT
 	select WEXT_PRIV
-	default n
 	help
 	  This is the wlan-ng prism 2.5/3 USB driver for a wide range of
 	  old USB wireless devices.

Powered by blists - more mailing lists