linux-kernel - Re: [PATCH v5 2/4] coresight: replicator: Add new device id for static replicator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <489e8aff-b279-b984-1cd2-f528a46eb2fe@arm.com>
Date:   Fri, 12 Apr 2019 11:41:11 +0100
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     leo.yan@...aro.org, mathieu.poirier@...aro.org, robh+dt@...nel.org,
        mark.rutland@....com, alexander.shishkin@...ux.intel.com,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/4] coresight: replicator: Add new device id for
 static replicator

On 04/12/2019 11:27 AM, Leo Yan wrote:
> This patch adds a device id for the new static replicator compatible
> string; it changes the driver name from "coresight-replicator" to
> "coresight-static-replicator" as well.
> 
> This patch also gives warning when use the replicator obsolete DT
> binding.
> 
> Signed-off-by: Leo Yan <leo.yan@...aro.org>
> ---
>   drivers/hwtracing/coresight/coresight-replicator.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c
> index 4e0da85efd2d..8c9ce74498e1 100644
> --- a/drivers/hwtracing/coresight/coresight-replicator.c
> +++ b/drivers/hwtracing/coresight/coresight-replicator.c
> @@ -189,6 +189,9 @@ static int replicator_probe(struct device *dev, struct resource *res)
>   		dev->platform_data = pdata;
>   	}
>   
> +	if (of_device_is_compatible(np, "arm,coresight-replicator"))
> +		pr_warn_once("Uses OBSOLETE CoreSight replicator binding\n");
> +
>   	drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL);
>   	if (!drvdata)
>   		return -ENOMEM;
> @@ -285,13 +288,14 @@ static const struct dev_pm_ops replicator_dev_pm_ops = {
>   
>   static const struct of_device_id static_replicator_match[] = {
>   	{.compatible = "arm,coresight-replicator"},
> +	{.compatible = "arm,coresight-static-replicator"},
>   	{}
>   };
>   
>   static struct platform_driver static_replicator_driver = {
>   	.probe          = static_replicator_probe,
>   	.driver         = {
> -		.name   = "coresight-replicator",
> +		.name   = "coresight-static-replicator",
>   		.of_match_table = static_replicator_match,
>   		.pm	= &replicator_dev_pm_ops,
>   		.suppress_bind_attrs = true,
> 

Reviewed-by: Suzuki K Poulose <suzuki.poulose@....com>