linux-kernel - Re: [PATCH] Fixed coding style: do not initialise statics to NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c26613c6-1212-8ccd-e762-c7280509844e@xs4all.nl>
Date:   Fri, 12 Apr 2019 12:48:40 +0200
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Tiago Macedo <tiagohenrique.macedo@...il.com>,
        gregkh@...uxfoundation.org
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        devel@...verdev.osuosl.org, lkcamp@...ts.libreplanetbr.org,
        Tiago Macedo <tiagohenrique.macedo@...i.com>
Subject: Re: [PATCH] Fixed coding style: do not initialise statics to NULL

Hi Tiago,

On 4/12/19 4:45 AM, Tiago Macedo wrote:
> The standard guarantees that a pointer with static storage duration
> and no other initializer will be initialized to be a null pointer.
> 
> Signed-off-by: Tiago Macedo <tiagohenrique.macedo@...i.com>
> ---
>  drivers/staging/media/zoran/videocodec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/zoran/videocodec.c b/drivers/staging/media/zoran/videocodec.c
> index c1ee5cb7e66b..cc6e0f1cd7b4 100644
> --- a/drivers/staging/media/zoran/videocodec.c
> +++ b/drivers/staging/media/zoran/videocodec.c
> @@ -51,7 +51,7 @@ struct codec_list {
>  	struct codec_list *next;
>  };
>  
> -static struct codec_list *codeclist_top = NULL;
> +static struct codec_list *codeclist_top;
>  
>  /* ================================================= */
>  /* function prototypes of the master/slave interface */
> 

I dropped this patch since the zoran driver will be removed for 5.2,
so there is no point in applying this patch.

Also, for future reference, please provide the name of the driver that
you are patching in the subject. I.e. something like this:

[PATCH] zoran: fixed coding style: do not initialise statics to NULL

That helps triage for maintainers.

Regards,

	Hans