linux-kernel - Re: [PATCH v5 1/4] dt-bindings: arm: coresight: Add new compatible for static replicator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190412105432.GA1643@leoy-ThinkPad-X240s>
Date:   Fri, 12 Apr 2019 18:54:32 +0800
From:   Leo Yan <leo.yan@...aro.org>
To:     Suzuki K Poulose <suzuki.poulose@....com>
Cc:     mathieu.poirier@...aro.org, robh+dt@...nel.org,
        mark.rutland@....com, alexander.shishkin@...ux.intel.com,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/4] dt-bindings: arm: coresight: Add new compatible
 for static replicator

On Fri, Apr 12, 2019 at 11:40:13AM +0100, Suzuki K Poulose wrote:
> On 04/12/2019 11:27 AM, Leo Yan wrote:
> > CoreSight uses below bindings for replicator:
> > 
> >    Dynamic replicator, aka. configurable replicator:
> >      "arm,coresight-dynamic-replicator", "arm,primecell";
> > 
> >    Static replicator, aka. non-configurable replicator:
> >      "arm,coresight-replicator";
> > 
> > The compatible string "arm,coresight-replicator" is not an explicit
> > naming to express the replicator is 'static'.  To unify the naming
> > convention, this patch introduces a new compatible string
> > "arm,coresight-static-replicator" for the static replicator; the
> > compatible string "arm,coresight-replicator" is kept for backward
> > compatibility, but tag it as obsolete and suggest to use the new
> > compatible string.
> > 
> > As result CoreSight replicator have below bindings:
> > 
> >    Dynamic replicator:
> >      "arm,coresight-dynamic-replicator", "arm,primecell";
> > 
> >    Static replicator:
> >      "arm,coresight-static-replicator";
> >      "arm,coresight-replicator"; (obsolete)
> > 
> > Signed-off-by: Leo Yan <leo.yan@...aro.org>
> > ---
> >   Documentation/devicetree/bindings/arm/coresight.txt | 7 +++++--
> >   1 file changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt
> > index f8aff65ab921..d02d160fa8ac 100644
> > --- a/Documentation/devicetree/bindings/arm/coresight.txt
> > +++ b/Documentation/devicetree/bindings/arm/coresight.txt
> > @@ -69,7 +69,10 @@ its hardware characteristcs.
> >   	* compatible: Currently supported value is (note the absence of the
> >   	  AMBA markee):
> > -		- "arm,coresight-replicator"
> > +		- Coresight Non-configurable Replicator:
> > +			"arm,coresight-static-replicator";
> > +			"arm,coresight-replicator"; (OBSOLETE. For backward
> > +				compatibility and will be removed)
> >   	* port or ports: see "Graph bindings for Coresight" below.
> > @@ -169,7 +172,7 @@ Example:
> >   		/* non-configurable replicators don't show up on the
> >   		 * AMBA bus.  As such no need to add "arm,primecell".
> >   		 */
> > -		compatible = "arm,coresight-replicator";
> > +		compatible = "arm,coresight-static-replicator";
> 
> Reviewed-by: Suzuki K Poulose <suzuki.poulose@....com>

Thanks a lot for quick reviewing, Suzuki.