lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <d032d8b2-3b21-03f2-ecad-fc0889f6011b@rock-chips.com> Date: Fri, 12 Apr 2019 09:53:57 +0800 From: "elaine.zhang" <zhangqing@...k-chips.com> To: Douglas Anderson <dianders@...omium.org>, Heiko Stuebner <heiko@...ech.de> Cc: dbasehore@...omium.org, amstan@...omium.org, linux-rockchip@...ts.infradead.org, briannorris@...omium.org, mka@...omium.org, ryandcase@...omium.org, Chris Zhong <zyw@...k-chips.com>, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH 4/5] ARM: dts: rockchip: vcc33_ccd off in suspend for rk3288-veyron-chromebook hi, 在 2019/4/12 上午7:21, Douglas Anderson 写道: > As per my comments when the device tree for rk3288-veyron-chromebook > first landed: > >> Technically I think vcc33_ccd can be off since we have >> 'needs-reset-on-resume' down in the EHCI port (this regulator is for >> the USB webcam that's connected to the EHCI port). >> >> ...but leaving it on for now seems fine until we get suspend/resume >> more solid. > It's probably about time to do it right. > > [1] https://lore.kernel.org/linux-arm-kernel/CAD=FV=U37Yx8Mqk75_x05zxonvdc3qRMhqp8TyTDPWGHqSuRqg@mail.gmail.com/ > > Signed-off-by: Douglas Anderson <dianders@...omium.org> > --- > > arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi > index b9cc90f0f25c..fbef34578100 100644 > --- a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi > +++ b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi > @@ -176,8 +176,7 @@ > regulator-min-microvolt = <3300000>; > regulator-max-microvolt = <3300000>; > regulator-state-mem { > - regulator-on-in-suspend; > - regulator-suspend-microvolt = <3300000>; > + regulator-off-in-suspend; > }; > }; > }; Reviewed-by: Elaine Zhang<zhangqing@...k-chips.com>
Powered by blists - more mailing lists