lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1c9542c4-08ba-24e6-6bb3-1aecc9741eec@huawei.com> Date: Fri, 12 Apr 2019 20:08:32 +0800 From: "wanghai (M)" <wanghai26@...wei.com> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> CC: <davem@...emloft.net>, <idosch@...lanox.com>, <eric.dumazet@...il.com>, <alexander.h.duyck@...el.com>, <tyhicks@...onical.com>, <f.fainelli@...il.com>, <viro@...iv.linux.org.uk>, <amritha.nambiar@...el.com>, <joe@...ches.com>, <dmitry.torokhov@...il.com>, <stephen@...workplumber.org>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 2/2] net-sysfs: Fix memory leak in netdev_register_kobject 在 2019/4/12 16:38, Andy Shevchenko 写道: > On Fri, Apr 12, 2019 at 04:36:34PM -0400, Wang Hai wrote: > >> +error_register: >> + device_del(dev); >> +error_device_add: >> + kfree_const(dev->kobj.name); >> return error; > When put_device() will be called on this it will go to double free (in case of > dynamically allocated dev->kobj.name. > > Al Viro and me suggested earlier that the correct fix is to call put_device() > in a places where it is appropriate. Thanks. I'll take a closer look at the code to see when it's time to call put_device(). It's really not easy to fix.
Powered by blists - more mailing lists