linux-kernel - Re: [PATCH V5 3/3] hwmon: pwm-fan: Add RPM support via external interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 12 Apr 2019 15:35:13 +0200
From:   Stefan Wahren <stefan.wahren@...e.com>
To:     "Enrico Weigelt, metux IT consult" <lkml@...ux.net>,
        Kamil Debski <kamil@...as.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Robin Murphy <robin.murphy@....com>
Cc:     linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V5 3/3] hwmon: pwm-fan: Add RPM support via external
 interrupt

Hi Enrico,

On 12.04.19 15:15, Enrico Weigelt, metux IT consult wrote:
> On 11.04.19 15:30, Stefan Wahren wrote:
>> This adds RPM support to the pwm-fan driver in order to use with
>> fancontrol/pwmconfig. This feature is intended for fans with a tachometer
>> output signal, which generate a defined number of pulses per revolution.
> Wouldn't it be better to have a CONFIG_* flag for keeping the kernel
> image size smaller when this feature isn't needed ?

i compared the kernel module size in linux-next for ARM without and with
this patch:
without patch: 12088 bytes
with patch: 14292 bytes

I don't think it is worth the trouble.

Stefan

>
>
> --mtx
>