lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 12 Apr 2019 15:48:02 +0200 From: Petr Mladek <pmladek@...e.com> To: Alastair D'Silva <alastair@....ibm.com> Cc: alastair@...ilva.org, Jani Nikula <jani.nikula@...ux.intel.com>, Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>, Rodrigo Vivi <rodrigo.vivi@...el.com>, David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>, Karsten Keil <isdn@...ux-pingi.de>, Jassi Brar <jassisinghbrar@...il.com>, Tom Lendacky <thomas.lendacky@....com>, "David S. Miller" <davem@...emloft.net>, Jose Abreu <Jose.Abreu@...opsys.com>, Kalle Valo <kvalo@...eaurora.org>, Stanislaw Gruszka <sgruszka@...hat.com>, Benson Leung <bleung@...omium.org>, Enric Balletbo i Serra <enric.balletbo@...labora.com>, "James E.J. Bottomley" <jejb@...ux.ibm.com>, "Martin K. Petersen" <martin.petersen@...cle.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Alexander Viro <viro@...iv.linux.org.uk>, Sergey Senozhatsky <sergey.senozhatsky@...il.com>, Steven Rostedt <rostedt@...dmis.org>, Andrew Morton <akpm@...ux-foundation.org>, intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, ath10k@...ts.infradead.org, linux-wireless@...r.kernel.org, linux-scsi@...r.kernel.org, linux-fbdev@...r.kernel.org, devel@...verdev.osuosl.org, linux-fsdevel@...r.kernel.org Subject: Re: [PATCH 1/4] lib/hexdump.c: Allow 64 bytes per line On Wed 2019-04-10 13:17:17, Alastair D'Silva wrote: > From: Alastair D'Silva <alastair@...ilva.org> > > With modern high resolution screens, we can display more data, which makes > life a bit easier when debugging. I have quite some doubts about this feature. We are talking about more than 256 characters per-line. I wonder if such a long line is really easier to read for a human. I am not expert but there is a reason why the standard is 80 characters per-line. I guess that anything above 100 characters is questionable. https://en.wikipedia.org/wiki/Line_length somehow confirms that. Second, if we take 8 pixels per-character. Then we need 2048 to show the 256 characters. It is more than HD. IMHO, there is still huge number of people that even do not have HD display, especially on a notebook. I am sorry but I am strongly against having this hardcoded anywhere. And I doubt that there will be enough users to complicate the code and make it configurable. Best Regards, Petr
Powered by blists - more mailing lists