linux-kernel - Re: [PATCH net-next 01/12] net: hns3: fix VLAN initialization to be compatible with port base insert VLAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a650f2c-7988-5ff3-68ad-909005fc50c9@huawei.com>
Date:   Fri, 12 Apr 2019 10:30:38 +0800
From:   tanhuazhong <tanhuazhong@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <salil.mehta@...wei.com>, <yisen.zhuang@...wei.com>,
        <linuxarm@...wei.com>, <shenjian15@...wei.com>
Subject: Re: [PATCH net-next 01/12] net: hns3: fix VLAN initialization to be
 compatible with port base insert VLAN



On 2019/4/12 2:20, David Miller wrote:
> From: Huazhong Tan <tanhuazhong@...wei.com>
> Date: Thu, 11 Apr 2019 20:25:20 +0800
> 
>> From: Jian Shen <shenjian15@...wei.com>
>>
>> This patch fixes VLAN initialization, in order to be compatible
>> with VLAN inserted base on port.
> 
> This doesn't mean anything to me.
> 
> Why was normal VLAN initialization different, and how is the behavior
> of VLAN's configured when inserted based upon port different and why
> is it better?
> 
> You have to improve your commit log messages so that someone not
> intimately familiar with your driver and code can understand what you
> are doing and why.
> 

Sorry, I will describe it in detail.

Our hardware supports insert a specified vlan header for each function 
when send packets. User can enable it with command "ip link set 
<devname> vf  <vfid> vlan <vlan id>".  For this vlan header is inserted 
by hardware, not from stack,  hardware also needs to strip it from 
received packet before upstreaming to stack.  In this case, driver needs 
to tell hardware which vlan to insert or strip.

Thanks.

> .
>