linux-kernel - Re: [PATCH] pci: endpoint: fix a potential NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 12 Apr 2019 15:41:25 +0100
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Kangjie Lu <kjlu@....edu>
Cc:     pakki001@....edu, Kishon Vijay Abraham I <kishon@...com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
        Niklas Cassel <niklas.cassel@...s.com>,
        Jia-Ju Bai <baijiaju1990@...il.com>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pci: endpoint: fix a potential NULL pointer dereference

On Fri, Mar 15, 2019 at 12:07:10AM -0500, Kangjie Lu wrote:
> In case alloc_workqueue, the fix returns -ENOMEM to avoid
> potential NULL pointer dereferences.
> 
> Signed-off-by: Kangjie Lu <kjlu@....edu>
> ---
>  drivers/pci/endpoint/functions/pci-epf-test.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
> index 3e86fa3c7da3..dc610eb1543a 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-test.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
> @@ -570,6 +570,10 @@ static int __init pci_epf_test_init(void)
>  
>  	kpcitest_workqueue = alloc_workqueue("kpcitest",
>  					     WQ_MEM_RECLAIM | WQ_HIGHPRI, 0);
> +	if (unlikely(!kpcitest_workqueue)) {
> +		pr_err("Failed to allocate the kpcitest work queue\n");
> +		return -ENOMEM;
> +	}
>  	ret = pci_epf_register_driver(&test_driver);
>  	if (ret) {
>  		pr_err("Failed to register pci epf test driver --> %d\n", ret);

Updated the code slighty and pushed out to pci/misc, thanks.

Lorenzo