lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <3e14cbf9-2cb0-1a5d-9c2f-aa9ca014c660@gmail.com> Date: Fri, 12 Apr 2019 19:49:50 +0200 From: Yurii Pavlovskyi <yurii.pavlovskyi@...il.com> To: Daniel Drake <drake@...lessm.com> Cc: Corentin Chary <corentin.chary@...il.com>, Darren Hart <dvhart@...radead.org>, Andy Shevchenko <andy@...radead.org>, acpi4asus-user <acpi4asus-user@...ts.sourceforge.net>, Platform Driver <platform-driver-x86@...r.kernel.org>, Linux Kernel <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 01/11] platform/x86: asus-wmi: Fix hwmon device cleanup Hello Daniel, thank you for the tip. I did not know about this function. It does indeed seem to make this complete patch redundant looking at 6e5f62b9e3651e61 hwmon: (lm90) Use devm_hwmon_device_register_with_groups I will surely implement it this way in the next version. Best regards, Yurii On 11.04.19 10:21, Daniel Drake wrote: > On Thu, Apr 11, 2019 at 4:21 AM Yurii Pavlovskyi > <yurii.pavlovskyi@...il.com> wrote: >> >> The asus-wmi driver does not clean up the hwmon device on exit or error. >> To reproduce the bug, repeat rmmod, insmod to verify that device number >> /sys/devices/platform/asus-nb-wmi/hwmon/hwmon?? grows every time. Add >> pointer to the device in module state and call cleanup on error. > > I wonder if this can be fixed more cleanly by using > devm_hwmon_device_register_with_groups() ? > > Thanks > Daniel >
Powered by blists - more mailing lists