linux-kernel - Re: [PATCH v2] arm64: dts: qcom: Add Lenovo Miix 630

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190412180142.GZ1843@tuxbook-pro>
Date:   Fri, 12 Apr 2019 11:01:42 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Jeffrey Hugo <jeffrey.l.hugo@...il.com>
Cc:     agross@...nel.org, david.brown@...aro.org, robh+dt@...nel.org,
        mark.rutland@....com, lee.jones@...aro.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: Add Lenovo Miix 630

On Thu 11 Apr 13:51 PDT 2019, Jeffrey Hugo wrote:
> diff --git a/arch/arm64/boot/dts/qcom/msm8998-clam.dtsi b/arch/arm64/boot/dts/qcom/msm8998-clam.dtsi
[..]
> +&tlmm {
> +	gpio-reserved-ranges = <0 4>, <81 4>;

Did you double check that you actually need these? (Iirc boot testing is
enough)

> +
> +	touchpad: touchpad {
> +		config {
> +			pins = "gpio123";
> +			bias-pull-up;           /* pull up */
> +		};
> +	};
> +};
[..]
> diff --git a/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts b/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts
[..]
> +/ {
> +	model = "Lenovo Miix 630";
> +	compatible = "qcom,msm8998-clam";

compatible = "lenovo,miix-630", "qcom,msm8998";

> +
> +	/* bootloader doesn't understand DT, so no qcom,board-id */

You can omit this comment, as I don't think people will miss these
non-standard properties.

Regards,
Bjorn