linux-kernel - Re: [PATCH 1/3] mm/memremap: Rename and consolidate SECTION

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPcyv4iYgwPJZpwUzM-ehc5F3gjO5TJ4AOz3f21ou8NrRCsEKA@mail.gmail.com>
Date:   Fri, 12 Apr 2019 12:12:49 -0700
From:   Dan Williams <dan.j.williams@...el.com>
To:     Robin Murphy <robin.murphy@....com>
Cc:     Linux MM <linux-mm@...ck.org>, "Weiny, Ira" <ira.weiny@...el.com>,
        Jérôme Glisse <jglisse@...hat.com>,
        ohall@...il.com, X86 ML <x86@...nel.org>,
        linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
        Anshuman Khandual <anshuman.khandual@....com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] mm/memremap: Rename and consolidate SECTION_SIZE

On Fri, Apr 12, 2019 at 11:57 AM Robin Murphy <robin.murphy@....com> wrote:
>
> Trying to activatee ZONE_DEVICE for arm64 reveals that memremap's

s/activatee/activate/

> internal helpers for sparsemem sections conflict with and arm64's
> definitions for hugepages, which inherit the name of "sections" from
> earlier versions of the ARM architecture.
>
> Disambiguate memremap (and now HMM too) by propagating sparsemem's PA_
> prefix, to clarify that these values are in terms of addresses rather
> than PFNs (and because it's a heck of a lot easier than changing all the
> arch code). SECTION_MASK is unused, so it can just go.

Looks good to me. So good that it collides with a similar change in
the "sub-section" support series.

Acked-by: Dan Williams <dan.j.williams@...el.com>