linux-kernel - Re: [PATCH v2 2/7] dt: bindings: Add multicolor class dt bindings documention

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19932d2d-28c4-9212-b38b-8b7008fb1d34@gmail.com>
Date:   Fri, 12 Apr 2019 21:24:13 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Dan Murphy <dmurphy@...com>, Marek Behun <marek.behun@....cz>
Cc:     robh+dt@...nel.org, pavel@....cz, rdunlap@...radead.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-leds@...r.kernel.org
Subject: Re: [PATCH v2 2/7] dt: bindings: Add multicolor class dt bindings
 documention

Dan,

On 4/12/19 8:46 PM, Dan Murphy wrote:
> Jacek
> 
> On 4/12/19 1:14 PM, Jacek Anaszewski wrote:
>> Hi Marek,
>>
>> On 4/12/19 12:07 AM, Marek Behun wrote:
>>> Hi Dan,
>>> this probaly was discussed, but I did not follow brightness model
>>> discussions:
>>> what will happen if I set yellow by writing into yellow mode
>>> brightness, and then orange by writing orange model brightness?
>>> Will the resulting color be a mix of yellow and orange, or will the
>>> orange overwrite the yellow setting?
>>
>> Orange will overwrite yellow settings. When color name is given
>> it should be treated as a hue. Then changing brightness level
>> should affect the lightness of a hue, similarly like changing
>> L component of HSL color model. This will be however entirely
>> up to DT brightness-model designer how they will design their models.
>> We are not going to verify that in the LED multi color class.
>>
>> It implies that it will be possible to define arbitrary range
>> of color levels, not necessarily adhering to any established color
>> model. I think it could be useful to define brightness model
>> that allows to go from blue color (for cold) up to red (hot)
>> for representing a temperature for instance.
>>
>> These ideas will need however more documentation. Generally
>> we aim to propose only a convention.
>>
> 
> Ah but what about the issue of writing the monochrome LED color.  With your description
> it implies that when we write the red LED, the red LED will come on and if we write the blue
> LED then the red LED in theory should turn off and the blue come on.

Where did I write that? Probably the way I used word "color"
was not adequate in at least two cases, which may have confused
the reader.

Modifying monochrome color brightness levels (under colors dir)
will just modify corresponding IOUT brightness. Not affecting the
other. I'll try to rephrase what seems to may sound equivocal:

s/When color name is given/When brightness-model is given a color name/

s/arbitrary range of color levels/arbitrary range of brightness-model 
levels/


> But these could be used to mix the colors to create some abstract violet that is not defined in the brightness
> model.  Why should the brightness models and monochrome LEDs have two different operations.
> 
> Dan
> 

-- 
Best regards,
Jacek Anaszewski