lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20190413110803.CC98C60779@smtp.codeaurora.org> Date: Sat, 13 Apr 2019 11:08:03 +0000 (UTC) From: Kalle Valo <kvalo@...eaurora.org> To: Colin King <colin.king@...onical.com> Cc: Arend van Spriel <arend.vanspriel@...adcom.com>, Franky Lin <franky.lin@...adcom.com>, Hante Meuleman <hante.meuleman@...adcom.com>, Chi-Hsien Lin <chi-hsien.lin@...ress.com>, Wright Feng <wright.feng@...ress.com>, "David S . Miller" <davem@...emloft.net>, linux-wireless@...r.kernel.org, brcm80211-dev-list.pdl@...adcom.com, brcm80211-dev-list@...ress.com, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH][V2] brcmfmac: fix leak of mypkt on error return path Colin King <colin.king@...onical.com> wrote: > From: Colin Ian King <colin.king@...onical.com> > > Currently if the call to brcmf_sdiod_set_backplane_window fails then > error return path leaks mypkt. Fix this by returning by a new > error path labelled 'out' that calls brcmu_pkt_buf_free_skb to free > mypkt. Also remove redundant check on err before calling > brcmf_sdiod_skbuff_write. > > Addresses-Coverity: ("Resource Leak") > Fixes: a7c3aa1509e2 ("brcmfmac: Remove brcmf_sdiod_addrprep()") > Signed-off-by: Colin Ian King <colin.king@...onical.com> > Reviewed-by: Mukesh Ojha <mojha@...eaurora.org> Patch applied to wireless-drivers-next.git, thanks. a927e8d8ab57 brcmfmac: fix leak of mypkt on error return path -- https://patchwork.kernel.org/patch/10891135/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists