linux-kernel - Re: [PATCH] block, Kconfig.iosched: set default value of IOSCHED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <802d43e0-1954-ddb8-9da6-973742e1bfb6@kernel.dk>
Date:   Sat, 13 Apr 2019 07:05:54 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Paolo Valente <paolo.valente@...aro.org>
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        ulf.hansson@...aro.org, linus.walleij@...aro.org,
        broonie@...nel.org, bfq-iosched@...glegroups.com,
        oleksandr@...alenko.name, Anders Roxell <anders.roxell@...aro.org>
Subject: Re: [PATCH] block, Kconfig.iosched: set default value of IOSCHED_BFQ
 to yes

On 4/13/19 3:16 AM, Paolo Valente wrote:
> When I added bfq to Kconfig.iosched, I forgot to add the line that
> sets to yes the default value of IOSCHED_BFQ, as it is the case for
> the other two I/O schedulers. Such a piece of information is used by
> popular build systems, when making kernel configs automatically. So,
> the lack of this line for bfq makes it hard and confusing to have bfq
> in the kernel generated by these systems.
> 
> This commit adds this missing line.

This only makes sense to do for newly introduced symbols. Apart from
that, we should not default to 'y' (or 'm' for that matter) what isn't
strictly needed. Looking at the io schedulers, kyber shouldn't have had
that added.

-- 
Jens Axboe