linux-kernel - Re: linux-next: build failure after merge of the netfilter-next tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190413140546.081e8196@canb.auug.org.au>
Date:   Sat, 13 Apr 2019 14:05:46 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Florian Westphal <fw@...len.de>
Cc:     Pablo Neira Ayuso <pablo@...filter.org>,
        NetFilter <netfilter-devel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Subject: Re: linux-next: build failure after merge of the netfilter-next
 tree

Hi Florian,

On Fri, 12 Apr 2019 10:15:27 +0200 Florian Westphal <fw@...len.de> wrote:
>
> Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> > After merging the netfilter tree, today's linux-next build (powerpc
> > ppc44x_defconfig) failed like this:
> > 
> > In file included from /home/sfr/next/next/net/bridge/br_input.c:19:
> > /home/sfr/next/next/include/net/netfilter/nf_queue.h:16:23: error: field 'state'
> >  has incomplete type
> >   struct nf_hook_state state;
> >                        ^~~~~
> > Caused by commit
> > 
> >   971502d77faa ("bridge: netfilter: unroll NF_HOOK helper in bridge input path")
> > 
> > This build has CONFIG_NETFILTER not set.
> > 
> > I have applied this patch for today:  
> 
> Can you submit this fix formally to netfilter-devel@...r.kernel.org?

Done.  Though I was hoping someone might come up with a better solution
(I don't particularly like conditional inclusions).

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped