lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 13 Apr 2019 09:14:18 +0200
From:   Nicholas Mc Guire <>
To:     Russell King <>
Cc:     Shawn Guo <>,
        Sascha Hauer <>,
        Pengutronix Kernel Team <>,
        Fabio Estevam <>,
        NXP Linux Team <>,
        Mark Brown <>,
        Linus Walleij <>,
        Tony Lindgren <>,
        Mike Rapoport <>,
        Janusz Krzysztofik <>,,,
        Nicholas Mc Guire <>
Subject: [PATCH] ARM: STi: at least warn if of_iomap fails

The call to of_iomap() is unchecked but scu_enable(), which the returned
address is passed on to, assumes a valid mapping. If the mapping is
invalid this could probably lead to undefined system state so at least
a warning should be issued.

Signed-off-by: Nicholas Mc Guire <>
Fixes: commit 65ebcc115889 ("ARM: sti: Add STiH415 SOC support")
Problem was found by an experimental coccinelle script

Patch was compile tested with: multi_v7_defconfig (implies

Patch is against 4.18-rc3 (localversion-next is next-20180712)

 arch/arm/mach-sti/platsmp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-sti/platsmp.c b/arch/arm/mach-sti/platsmp.c
index 231f19e..89ae76f 100644
--- a/arch/arm/mach-sti/platsmp.c
+++ b/arch/arm/mach-sti/platsmp.c
@@ -109,6 +109,7 @@ static void __init sti_smp_prepare_cpus(unsigned int max_cpus)
 	if (np) {
 		scu_base = of_iomap(np, 0);
+		WARN_ON(!scu_base);

Powered by blists - more mailing lists