linux-kernel - Re: [PATCH 04/12] phy: tegra: add missing of_node_put after of_device_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 14 Apr 2019 17:42:15 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Julia Lawall <Julia.Lawall@...6.fr>,
        Mukesh Ojha <mojha@...eaurora.org>, linux-tegra@...r.kernel.org
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jonathan Hunter <jonathanh@...dia.com>,
        Thierry Reding <thierry.reding@...il.com>
Subject: Re: [PATCH 04/12] phy: tegra: add missing of_node_put after
 of_device_is_available

> @@ -260,8 +260,10 @@  tegra_xusb_pad_create(struct tegra_xusb_
>  	int err;
>
>  	np = tegra_xusb_find_pad_node(padctl, soc->name);
> -	if (!np || !of_device_is_available(np))
> +	if (!np || !of_device_is_available(np)) {
> +		of_node_put(np);
>  		return NULL;
> +	}
>
>  	pad = soc->ops->probe(padctl, soc, np);
>  	if (IS_ERR(pad)) {

How do you think about to move this function call to an additional jump target
for the desired exception handling?

Regards,
Markus