linux-kernel - Re: [PATCH] soundwire: intel: fix implicit header use of module.h/export.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190414102314.GL28103@vkoul-mobl>
Date:   Sun, 14 Apr 2019 15:53:14 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     linux-kernel@...r.kernel.org,
        Sanyog Kale <sanyog.r.kale@...el.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Subject: Re: [PATCH] soundwire: intel: fix implicit header use of
 module.h/export.h

On 13-04-19, 11:12, Paul Gortmaker wrote:
> These two files are implicitly relying on an instance of including
> module.h from <linux/acpi.h>.
> 
> Ideally, header files under include/linux shouldn't be adding
> includes of other headers, in anticipation of their consumers,
> but just the headers needed for the header itself to pass
> parsing with CPP.
> 
> The module.h is particularly bad in this sense, as it itself does
> include a whole bunch of other headers, due to the complexity of
> module support.
> 
> Here, we make those includes explicit, in order to allow a future
> removal of module.h from linux/acpi.h without causing build breakage.

Applied, thanks

-- 
~Vinod