linux-kernel - Re: linux-next: Tree for Apr 8 (iio/adc/)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 14 Apr 2019 13:30:59 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-iio@...r.kernel.org, Fabrice Gasnier <fabrice.gasnier@...com>
Subject: Re: linux-next: Tree for Apr 8 (iio/adc/)

On Mon, 8 Apr 2019 09:09:37 -0700
Randy Dunlap <rdunlap@...radead.org> wrote:

> On 4/7/19 10:41 PM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Changes since 20190405:
> >   
> 
> on i386 or x86_64:
> 
> modular:
> ERROR: "is_stm32_timer_trigger" [drivers/iio/adc/stm32-dfsdm-adc.ko] undefined!
> 
> or builtin:
> ld: drivers/iio/adc/stm32-dfsdm-adc.o: in function `stm32_dfsdm_postenable':
> stm32-dfsdm-adc.c:(.text+0x878): undefined reference to `is_stm32_timer_trigger'
> 
> 
> Full i386 randconfig file is attached.
> 
Thanks Randy.

So two possible fixes for this one.  We can do what is done for the
stm32-adc driver and select IIO_STM_TIMER_TRIGGER or we can add a stub
for this function in the header to make it return false if that
driver isn't built.

I personally favour the stub option but would like Fabrice to say what
makes more sense.

So Fabrice, which of the above? If you are busy and don't get back
in the next day or two, I'll add the stub.

Thanks,

Jonathan