lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 15 Apr 2019 20:59:30 +0200
From:   Greg Kroah-Hartman <>
Cc:     Greg Kroah-Hartman <>,, Micah Parrish <>,
        Sergey Miroshnichenko <>,
        Bjorn Helgaas <>,
        Lukas Wunner <>
Subject: [PATCH 4.19 092/101] PCI: pciehp: Ignore Link State Changes after powering off a slot

From: Sergey Miroshnichenko <>

commit 3943af9d01e94330d0cfac6fccdbc829aad50c92 upstream.

During a safe hot remove, the OS powers off the slot, which may cause a
Data Link Layer State Changed event.  The slot has already been set to
OFF_STATE, so that event results in re-enabling the device, making it
impossible to safely remove it.

Clear out the Presence Detect Changed and Data Link Layer State Changed
events when the disabled slot has settled down.

It is still possible to re-enable the device if it remains in the slot
after pressing the Attention Button by pressing it again.

Fixes the problem that Micah reported below: an NVMe drive power button may
not actually turn off the drive.

Reported-by: Micah Parrish <>
Tested-by: Micah Parrish <>
Signed-off-by: Sergey Miroshnichenko <>
[bhelgaas: changelog, add bugzilla URL]
Signed-off-by: Bjorn Helgaas <>
Reviewed-by: Lukas Wunner <>
Cc:	# v4.19+
Signed-off-by: Greg Kroah-Hartman <>

 drivers/pci/hotplug/pciehp_ctrl.c |    4 ++++
 1 file changed, 4 insertions(+)

--- a/drivers/pci/hotplug/pciehp_ctrl.c
+++ b/drivers/pci/hotplug/pciehp_ctrl.c
@@ -117,6 +117,10 @@ static void remove_board(struct slot *p_
 		 * removed from the slot/adapter.
+		/* Ignore link or presence changes caused by power off */
+			   &ctrl->pending_events);
 	/* turn off Green LED */

Powered by blists - more mailing lists