lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 15 Apr 2019 22:07:26 +0200
From:   Pavel Machek <>
To:     Greg Kroah-Hartman <>
        Jarkko Nikula <>,
        Andy Lutomirski <>,
        "Rafael J. Wysocki" <>,
        Thomas Gleixner <>,
        Borislav Petkov <>,
        Josh Poimboeuf <>,
        Linus Torvalds <>,
        Peter Zijlstra <>,
        "Rafael J. Wysocki" <>,
        Zhang Rui <>,
        Ingo Molnar <>, Sasha Levin <>
Subject: Re: [PATCH 4.14 03/69] x86/power/64: Use struct desc_ptr for the IDT
 in struct saved_context

On Mon 2019-04-15 20:58:21, Greg Kroah-Hartman wrote:
> [ Upstream commit 090edbe23ff57940fca7f57d9165ce57a826bd7a ]
> x86_64's saved_context nonsensically used separate idt_limit and
> idt_base fields and then cast &idt_limit to struct desc_ptr *.
> This was correct (with -fno-strict-aliasing), but it's confusing,
> served no purpose, and required #ifdeffery. Simplify this by
> using struct desc_ptr directly.
> No change in functionality.

While this is nice cleanup, I don't think it fixes real bug. I don't
think it is suitable for stable.

(cesky, pictures)

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)

Powered by blists - more mailing lists