linux-kernel - Re: [PATCH v3 1/2] dt-bindings: power: supply: Add charge-status-gpios property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190415200951.jcp2ksfn7osucyxh@earth.universe>
Date:   Mon, 15 Apr 2019 22:09:51 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Artur Rojek <contact@...ur-rojek.eu>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Paul Cercueil <paul@...pouillou.net>,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: power: supply: Add
 charge-status-gpios property

Hi,

On Sun, Apr 14, 2019 at 02:40:38PM +0200, Artur Rojek wrote:
> Add documentation for the "charge-status-gpios" property.
> Update the "gpios" property with a valid example.
> 
> Signed-off-by: Artur Rojek <contact@...ur-rojek.eu>
> Reviewed-by: Rob Herring <robh@...nel.org>
> ---

Thanks, both queued.

-- Sebastian

> 
> Changes:
> 
> v2: - add a better description for the "status-gpios" property,
>     - add valid examples for the "gpios" and "status-gpios" properties
> 
> v3: rename the "status-gpios" property to "charge-status-gpios"
> 
>  .../devicetree/bindings/power/supply/gpio-charger.txt       | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/gpio-charger.txt b/Documentation/devicetree/bindings/power/supply/gpio-charger.txt
> index adbb5dc5b6e9..30349332f051 100644
> --- a/Documentation/devicetree/bindings/power/supply/gpio-charger.txt
> +++ b/Documentation/devicetree/bindings/power/supply/gpio-charger.txt
> @@ -14,12 +14,16 @@ Required properties :
>       usb-cdp (USB charging downstream port)
>       usb-aca (USB accessory charger adapter)
>  
> +Optional properties:
> + - charge-status-gpios: GPIO indicating whether a battery is charging.
> +
>  Example:
>  
>  	usb_charger: charger {
>  		compatible = "gpio-charger";
>  		charger-type = "usb-sdp";
> -		gpios = <&gpf0 2 0 0 0>;
> +		gpios = <&gpd 28 GPIO_ACTIVE_LOW>;
> +		charge-status-gpios = <&gpc 27 GPIO_ACTIVE_LOW>;
>  	}
>  
>  	battery {
> -- 
> 2.21.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)