linux-kernel - Re: [PATCH] kernel/workqueue: Verify alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6171ae280e2056cf21adc4481dd9b98e47cc6a30.camel@linux.intel.com>
Date:   Mon, 15 Apr 2019 13:46:46 -0700
From:   Alexander Duyck <alexander.h.duyck@...ux.intel.com>
To:     Bart Van Assche <bvanassche@....org>, Tejun Heo <tj@...nel.org>
Cc:     linux-kernel@...r.kernel.org,
        Lai Jiangshan <jiangshanlai@...il.com>,
        Dan Williams <dan.j.williams@...el.com>
Subject: Re: [PATCH] kernel/workqueue: Verify alloc_workqueue() argument
 list consistency

On Mon, 2019-04-15 at 10:09 -0700, Bart Van Assche wrote:
> On Tue, 2019-03-19 at 10:40 -0700, Bart Van Assche wrote:
> > This patch avoids that gcc reports the following warning when building
> > with W=1:
> > 
> > kernel/workqueue.c:4250:2: warning: function alloc_workqueue might be a candidate for gnu_printf format attribute [-Wsuggest-attribute=format]
> >   vsnprintf(wq->name, sizeof(wq->name), fmt, args);
> > 
> > Cc: Lai Jiangshan <jiangshanlai@...il.com>
> > Cc: Alexander Duyck <alexander.h.duyck@...ux.intel.com>
> > Cc: Dan Williams <dan.j.williams@...el.com>
> > Fixes: 669de8bda87b ("kernel/workqueue: Use dynamic lockdep keys for workqueues")
> > Signed-off-by: Bart Van Assche <bvanassche@....org>
> > ---
> >  include/linux/workqueue.h | 1 
> >  1 file changed, 1 insertion()
> > 
> > diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
> > index d59525fca4d3..30737b5183c0 100644
> > --- a/include/linux/workqueue.h
> > ﯦﾊ眥맗뾖⧮쟼⢮䪮竧ꇣ为 ,7 @@ extern struct workqueue_struct *system_freezable_power_efficient_wq;
> >   * RETURNS:
> >   * Pointer to the allocated workqueue on success, %NULL on failure.
> >   */
> > __printf(1, 4)
> >  struct workqueue_struct *alloc_workqueue(const char *fmt,
> >  					 unsigned int flags,
> >  					 int max_active, ...);
> 
> Ping?
> 
> Bart.

I'm not sure if your Cc list is really the right people to be reviewing
the patch. Wouldn't it make more sense to Cc the people who were on the
original patch that you are now fixing?