linux-kernel - [PATCH] pci: fix warning for struct hisi_pcie_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 Apr 2019 16:53:49 +0800
From:   Mao Wenan <maowenan@...wei.com>
To:     <wangzhou1@...ilicon.com>, <lorenzo.pieralisi@....com>,
        <bhelgaas@...gle.com>
CC:     <linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: [PATCH] pci: fix warning for struct hisi_pcie_platform_ops

There is one warning exist while compiling drivers/pci/controller/dwc/pcie-hisi.c.
make allmodconfig ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-
make C=2 drivers/pci/controller/dwc/pcie-hisi.o ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-
drivers/pci/controller/dwc/pcie-hisi.c:365:21: warning: symbol 'hisi_pcie_platform_ops' was not declared. Should it be static?

Fixes: a2ec1996098("PCI: hisi: Add DT almost-ECAM support for Hip06/Hip07 host controllers")
Reported-by: Hulk Robot <hulkci@...wei.com>
Signed-off-by: Mao Wenan <maowenan@...wei.com>
---
 drivers/pci/controller/dwc/pcie-hisi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-hisi.c b/drivers/pci/controller/dwc/pcie-hisi.c
index 6d9e1b2..11f5ff7 100644
--- a/drivers/pci/controller/dwc/pcie-hisi.c
+++ b/drivers/pci/controller/dwc/pcie-hisi.c
@@ -362,7 +362,7 @@ static int hisi_pcie_platform_init(struct pci_config_window *cfg)
 	return 0;
 }
 
-struct pci_ecam_ops hisi_pcie_platform_ops = {
+static struct pci_ecam_ops hisi_pcie_platform_ops = {
 	.bus_shift    = 20,
 	.init         =  hisi_pcie_platform_init,
 	.pci_ops      = {
-- 
2.7.4