[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190415085148.GC13124@krava>
Date: Mon, 15 Apr 2019 10:51:48 +0200
From: Jiri Olsa <jolsa@...hat.com>
To: Jin Yao <yao.jin@...ux.intel.com>
Cc: acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
mingo@...hat.com, alexander.shishkin@...ux.intel.com,
Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v4 0/4] perf: Support a new 'percore' event qualifier
On Fri, Apr 12, 2019 at 09:59:46PM +0800, Jin Yao wrote:
> The 'percore' event qualifier which sums up the event counts for both
> hardware threads in a core. For example,
>
> perf stat -e cpu/event=0,umask=0x3,percore=1/,cpu/event=0,umask=0x3/
>
> In this example, we count the event 'ref-cycles' per-core and per-CPU in
> one perf stat command-line.
>
> We can already support per-core counting with --per-core, but it's
> often useful to do this together with other metrics that are collected
> per CPU (per hardware thread). So this patch series supports this
> per-core counting on a event level.
>
> v4:
> ---
> Add percore qualifier to documantation.
> Rebase to latest perf/core branch
Acked-by: Jiri Olsa <jolsa@...nel.org>
thanks,
jirka
>
> v3:
> ---
> Simplify the patch: "perf: Add a 'percore' event qualifier"
> Other patches don't have changes.
>
> v2:
> ---
> 1. Change 'coresum' to 'percore'.
> 2. Move the aggregate counts printing to a seperate patch.
>
> Jin Yao (4):
> perf: Add a 'percore' event qualifier
> perf stat: Factor out aggregate counts printing
> perf stat: Support 'percore' event qualifier
> perf test: Add a simple test for term 'percore'
>
> tools/perf/Documentation/perf-list.txt | 12 ++++
> tools/perf/Documentation/perf-stat.txt | 4 ++
> tools/perf/builtin-stat.c | 21 +++++++
> tools/perf/tests/parse-events.c | 10 ++-
> tools/perf/util/evsel.c | 2 +
> tools/perf/util/evsel.h | 3 +
> tools/perf/util/parse-events.c | 27 +++++++++
> tools/perf/util/parse-events.h | 1 +
> tools/perf/util/parse-events.l | 1 +
> tools/perf/util/stat-display.c | 107 ++++++++++++++++++++++++---------
> tools/perf/util/stat.c | 8 ++-
> 11 files changed, 163 insertions(+), 33 deletions(-)
>
> --
> 2.7.4
>
Powered by blists - more mailing lists