linux-kernel - Re: [PATCH] perf/report: Report OOM in perf report status line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190415101728.GA6966@linux.ibm.com>
Date:   Mon, 15 Apr 2019 12:17:28 +0200
From:   Hendrik Brueckner <brueckner@...ux.ibm.com>
To:     Thomas Richter <tmricht@...ux.ibm.com>
Cc:     linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        acme@...nel.org, brueckner@...ux.vnet.ibm.com,
        schwidefsky@...ibm.com, heiko.carstens@...ibm.com
Subject: Re: [PATCH] perf/report: Report OOM in perf report status line

Thomas,

On Mon, Apr 15, 2019 at 11:46:17AM +0200, Thomas Richter wrote:
[...]

> Signed-off-by: Thomas Richter <tmricht@...ux.ibm.com>
> Reviewed-by: Jiri Olsa <jolsa@...hat.com>
> ---
>  tools/perf/util/session.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> index b17f1c9bc965..e89716175588 100644
> --- a/tools/perf/util/session.c
> +++ b/tools/perf/util/session.c
> @@ -1930,10 +1930,10 @@ reader__process_events(struct reader *rd, struct perf_session *session,
> 
>  	if (size < sizeof(struct perf_event_header) ||
>  	    (skip = rd->process(session, event, file_pos)) < 0) {
> -		pr_err("%#" PRIx64 " [%#x]: failed to process type: %d\n",
> +		pr_err("%#" PRIx64 " [%#x]: failed to process type: %d [%s]\n",
>  		       file_offset + head, event->header.size,
> -		       event->header.type);
> -		err = -EINVAL;
> +		       event->header.type, strerror(-skip));
> +		err = skip;
>  		goto out;
>  	}
> 

Thanks for solving this issue.

Reviewed-by: Hendrik Brueckner <brueckner@...ux.ibm.com>