linux-kernel - Re: [PATCH V5 1/7] jump_label: Add for_each_label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7243145-03cc-d7c6-4d0f-f25ec1fe3834@redhat.com>
Date:   Mon, 15 Apr 2019 13:29:33 +0200
From:   Daniel Bristot de Oliveira <bristot@...hat.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        "Steven Rostedt (VMware)" <rostedt@...dmis.org>,
        Jiri Kosina <jkosina@...e.cz>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Chris von Recklinghausen <crecklin@...hat.com>,
        Jason Baron <jbaron@...mai.com>, Scott Wood <swood@...hat.com>,
        Marcelo Tosatti <mtosatti@...hat.com>,
        Clark Williams <williams@...hat.com>, x86@...nel.org
Subject: Re: [PATCH V5 1/7] jump_label: Add for_each_label_entry helper

On 4/15/19 12:51 PM, Peter Zijlstra wrote:
>> +#define for_each_label_entry(key, entry, stop)				  \
>> +	for (; (entry < stop) && (jump_entry_key(entry) == key); entry++)
>> +
> I don't really like this naming; most (all?) for_each_*() loops start
> iteration and have the iteration variable as first argument.
> 
> This should maybe be called:
> 
> 	for_each_jump_entry_by_key_cont(entry, stop, key)
> 
> and I realize that is a horrible name too.

Borislav did not like this helper too, so I am convinced: we do not need it. I
will remove it in the next version.

-- Daniel