linux-kernel - Re: [PATCH] printk: tie printk_once / printk_deferred

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 15 Apr 2019 14:34:59 +0200
From:   Petr Mladek <pmladek@...e.com>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Cc:     Paul Gortmaker <paul.gortmaker@...driver.com>,
        linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] printk: tie printk_once / printk_deferred_once into
 .data.once for reset

On Mon 2019-04-15 11:32:16, Sergey Senozhatsky wrote:
> On (04/12/19 22:11), Paul Gortmaker wrote:
> > In commit b1fca27d384e ("kernel debug: support resetting WARN*_ONCE")
> > we got the opportunity to reset state on the one shot messages,
> > without having to reboot.
> 
> Didn't know that.
> 
> > However printk_once (printk_deferred_once) live in a different file
> > and didn't get the same kind of update/conversion, so they remain
> > unconditionally one shot, until the system is rebooted.
> > 
> > For example, we currently have:
> > 
> >   sched/rt.c: printk_deferred_once("sched: RT throttling activated\n");
> > 
> > ..which could reasonably be tripped as someone is testing and tuning
> > a new system/workload and their task placements.  For consistency, and
> > to avoid reboots in the same vein as the original commit, we make these
> > two instances of _once the same as the WARN*_ONCE instances are.
> 
> Looks OK to me.
> 
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>

The patch has been commited into printk.git, branch for-5.2.

Best Regards,
Petr