lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 15 Apr 2019 14:53:33 +0200
From:   Jiri Olsa <>
To:     Arnaldo Carvalho de Melo <>
Cc:     lkml <>,
        Ingo Molnar <>,
        Namhyung Kim <>,
        Alexander Shishkin <>,
        Peter Zijlstra <>,
        Bastian Beischer <>
Subject: [PATCH perf/urgent] perf top: Always sample time

Bastian reported broken perf top -p PID command, it won't
display any data.

The problem is that for -p option we monitor single thread,
so we don't enable time in samples, because it's not needed.

However since commit 16c66bc167cc we use ordered queues to
stash data plus later commits added logic for dropping samples
in case there's big load and we don't keep up. All this needs
timestamp for sample. Enabling it unconditionally for perf top.

Fixes: 16c66bc167cc ("perf top: Add processing thread")
Reported-by: Bastian Beischer <>
Signed-off-by: Jiri Olsa <>
 tools/perf/builtin-top.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 1999d6533d12..fbbb0da43abb 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -1377,6 +1377,7 @@ int cmd_top(int argc, const char **argv)
 			 * */
 			.overwrite	= 0,
 			.sample_time	= true,
+			.sample_time_set = true,
 		.max_stack	     = sysctl__max_stack(),
 		.annotation_opts     = annotation__default_options,

Powered by blists - more mailing lists