linux-kernel - Re: [PATCH v5 0/5] init: Do not select DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jLRnq1WeDtMSwE_qnve_O9+GiZd4m=N=_1rBidwRwmeJg@mail.gmail.com>
Date:   Sun, 14 Apr 2019 20:55:55 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Sinan Kaya <okaya@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Josh Triplett <josh@...htriplett.org>
Subject: Re: [PATCH v5 0/5] init: Do not select DEBUG_KERNEL by default

On Sat, Apr 13, 2019 at 3:44 PM Sinan Kaya <okaya@...nel.org> wrote:
>
> CONFIG_DEBUG_KERNEL has been designed to just enable Kconfig options.
> Kernel code generatoin should not depend on CONFIG_DEBUG_KERNEL.
>
> Proposed alternative plan: let's add a new symbol, something like
> DEBUG_MISC ("Miscellaneous debug code that should be under a more
> specific debug option but isn't"), make it depend on DEBUG_KERNEL and be
> "default DEBUG_KERNEL" but allow itself to be turned off, and then
> mechanically change the small handful of "#ifdef CONFIG_DEBUG_KERNEL" to
> "#ifdef CONFIG_DEBUG_MISC".

Thanks! This looks good to me. For the series:

Reviewed-by: Kees Cook <keescook@...omium.org>

Andrew, can you take these from lkml, or should the series get resent
directly to you? I think you might be the best to carry this?

Thanks!

-Kees

>
> Diff from v4:
> - collect reviewed-by
> - collect acked-by
> - fix nit on 1/5
>
> Sinan Kaya (5):
>   init: Introduce DEBUG_MISC option
>   powerpc: Replace CONFIG_DEBUG_KERNEL with CONFIG_DEBUG_MISC
>   mips: Replace CONFIG_DEBUG_KERNEL with CONFIG_DEBUG_MISC
>   xtensa: Replace CONFIG_DEBUG_KERNEL with CONFIG_DEBUG_MISC
>   net: Replace CONFIG_DEBUG_KERNEL with CONFIG_DEBUG_MISC
>
>  arch/mips/kernel/setup.c           | 2 +-
>  arch/powerpc/kernel/sysfs.c        | 8 ++++----
>  arch/xtensa/include/asm/irqflags.h | 2 +-
>  arch/xtensa/kernel/smp.c           | 2 +-
>  lib/Kconfig.debug                  | 9 +++++++++
>  net/netfilter/core.c               | 2 +-
>  6 files changed, 17 insertions(+), 8 deletions(-)
>
> --
> 2.21.0
>


-- 
Kees Cook