linux-kernel - Re: misuse of fget_raw() in perf_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190415044158.5goa2je57j63kwaz@ast-mbp.dhcp.thefacebook.com>
Date:   Sun, 14 Apr 2019 21:42:00 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        peterz@...radead.org, tj@...nel.org
Subject: Re: misuse of fget_raw() in perf_event_get()

On Sat, Apr 13, 2019 at 10:02:42PM +0100, Al Viro wrote:
> 	What's the point of using fget_raw(), if you do
> _not_ accept O_PATH descriptors?  That should be fget()...

I think you're talking about commit e03e7ee34fdd ("perf/bpf: Convert perf_event_array to use struct file")
I don't really remember why we went with this instead of fget().
There was a bunch of back and forth back then with Peter.
Now it looks like that it can be fget just fine.
I think cgroup_get_from_fd() should do the same too?