linux-kernel - Re: [PATCH 5/5] leds: lm3697: Introduce the lm3697 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 Apr 2019 16:03:06 +0200
From:   Pavel Machek <pavel@....cz>
To:     Dan Murphy <dmurphy@...com>
Cc:     robh+dt@...nel.org, jacek.anaszewski@...il.com,
        linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org
Subject: Re: [PATCH 5/5] leds: lm3697: Introduce the lm3697 driver


> >> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> >> index 735009e73414..688bb9a6f275 100644
> >> --- a/drivers/leds/Kconfig
> >> +++ b/drivers/leds/Kconfig
> >> @@ -776,9 +776,15 @@ config LEDS_NIC78BX
> >>  	  To compile this driver as a module, choose M here: the module
> >>  	  will be called leds-nic78bx.
> >>  
> >> +config LEDS_LM3697
> >> +	tristate "LED driver for LM3697"
> >> +	depends on LEDS_TI_LMU_COMMON
> >> +	help
> >> +	  Say Y to enable the LM3697 LED driver for TI LMU devices.
> >> +	  This supports the LED device LM3697.
> >> +
> >>  config LEDS_TI_LMU_COMMON
> >>  	tristate "LED driver for TI LMU"
> >> -	depends on REGMAP
> >>  	help
> >>            Say Y to enable the LED driver for TI LMU devices.
> >>            This supports common features between the TI LM3532, LM3631, LM3632,
...
> > Plus we'd normally expect "COMMON" first and then specific driver. Not
> > sure if Kconfig can handle it out-of-order...
> 
> OK.  Should I rename the ti_lmu file to leds-common-ti-lmu?

Oh, no, that is not what I meant.

You have

config B
       depends on A

config A

above. We really want

config A

config B
       depends on A

> This keeps the naming convention the same in the leds directory as well.
> 
> FYI I will not add your acked-by on the LMU patch that introduced the code unless you approve.
> Since you found issues with the kconfig

I did not review it in great detail, so no acked-by's, yet :-).
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)