linux-kernel - Re: [PATCH -next] PCI: mvebu: Make mvebu_pci_bridge_emul

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6852d7a5-3f0f-ee82-89ef-f3d5caf7bd83@huawei.com>
Date:   Mon, 15 Apr 2019 22:06:28 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>
CC:     <thomas.petazzoni@...tlin.com>, <jason@...edaemon.net>,
        <bhelgaas@...gle.com>, <gustavo.pimentel@...opsys.com>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-pci@...r.kernel.org>
Subject: Re: [PATCH -next] PCI: mvebu: Make mvebu_pci_bridge_emul_ops static

On 2019/4/15 21:00, Lorenzo Pieralisi wrote:
> On Wed, Apr 10, 2019 at 10:09:49PM +0800, Yue Haibing wrote:
>> From: YueHaibing <yuehaibing@...wei.com>
>>
>> Fix sparse warning:
>>
>> drivers/pci/controller/pci-mvebu.c:557:28: warning:
>>  symbol 'mvebu_pci_bridge_emul_ops' was not declared. Should it be static?
>>
>> Reported-by: Hulk Robot <hulkci@...wei.com>
> 
> Is Mr.Robot reachable by email ?
> 
> If it is a CI bot I doubt it is useful to leave this tag there unless
> you want it for accounting purposes, just let me know.

Yes, it is our CI bot.

> 
> Thanks,
> Lorenzo
> 
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>> ---
>>  drivers/pci/controller/pci-mvebu.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c
>> index d3a0419..ed032e9 100644
>> --- a/drivers/pci/controller/pci-mvebu.c
>> +++ b/drivers/pci/controller/pci-mvebu.c
>> @@ -554,7 +554,7 @@ mvebu_pci_bridge_emul_pcie_conf_write(struct pci_bridge_emul *bridge,
>>  	}
>>  }
>>  
>> -struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = {
>> +static struct pci_bridge_emul_ops mvebu_pci_bridge_emul_ops = {
>>  	.write_base = mvebu_pci_bridge_emul_base_conf_write,
>>  	.read_pcie = mvebu_pci_bridge_emul_pcie_conf_read,
>>  	.write_pcie = mvebu_pci_bridge_emul_pcie_conf_write,
>> -- 
>> 2.7.4
>>
>>
> 
> .
>