linux-kernel - Re: [PATCH] Staging: greybus: Cleanup in header file control.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190415150333.GE775@localhost>
Date:   Mon, 15 Apr 2019 17:03:33 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Johan Hovold <johan@...nel.org>, devel@...verdev.osuosl.org,
        elder@...nel.org, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org,
        Madhumitha Prabakaran <madhumithabiw@...il.com>,
        greybus-dev@...ts.linaro.org
Subject: Re: [PATCH] Staging: greybus: Cleanup in header file control.h

On Mon, Apr 15, 2019 at 05:40:16PM +0300, Dan Carpenter wrote:
> What I'm saying is that if we just apply it then we avoid the long
> discussion forever.  The macro is OK, sure, but it's not like anyone is
> going to come back later and argue that macros are better or preferred.

That may be a valid argument, at least with respect to staging
currently (even if checkpatch isn't entirely too blame for this
particular "cleanup").

But then all eight or so instances should be replaced in one go, to
maintain consistency.

Johan