linux-kernel - Re: [PATCH] fs/reiserfs/journal.c: Make remove_journal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190415150639.GA32075@bharath12345-Inspiron-5559>
Date:   Mon, 15 Apr 2019 20:36:39 +0530
From:   Bharath Vedartham <linux.bhar@...il.com>
To:     Jan Kara <jack@...e.cz>
Cc:     keescook@...omium.org, arnd@...db.de, akpm@...ux-foundation.org,
        reiserfs-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/reiserfs/journal.c: Make remove_journal_hash static

On Mon, Apr 15, 2019 at 11:47:39AM +0200, Jan Kara wrote:
> On Sun 14-04-19 16:54:38, Bharath Vedartham wrote:
> > This fixes the -WDecl sparse warning in journal.c. Function was declared
> > as static void but the definition was void.
> > 
> > Signed-off-by: Bharath Vedartham <linux.bhar@...il.com>
> 
> Thanks! I've added your patch into my tree.
>
Thanks Jan!
> 								Honza
> 
> > ---
> >  fs/reiserfs/journal.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c
> > index 8a76f9d..36346dc 100644
> > --- a/fs/reiserfs/journal.c
> > +++ b/fs/reiserfs/journal.c
> > @@ -1844,7 +1844,7 @@ static int flush_used_journal_lists(struct super_block *s,
> >   * removes any nodes in table with name block and dev as bh.
> >   * only touchs the hnext and hprev pointers.
> >   */
> > -void remove_journal_hash(struct super_block *sb,
> > +static void remove_journal_hash(struct super_block *sb,
> >  			 struct reiserfs_journal_cnode **table,
> >  			 struct reiserfs_journal_list *jl,
> >  			 unsigned long block, int remove_freed)
> > -- 
> > 2.7.4
> > 
> -- 
> Jan Kara <jack@...e.com>
> SUSE Labs, CR