linux-kernel - Re: [PATCH v2 0/2] Fix two bugs of switchtec module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac314aa2-951b-58c7-cfd6-65e53b5b5f1e@deltatee.com>
Date:   Mon, 15 Apr 2019 09:51:30 -0600
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Wesley Sheng <wesley.sheng@...rochip.com>,
        kurt.schwemmer@...rosemi.com, bhelgaas@...gle.com,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     wesleyshenggit@...a.com
Subject: Re: [PATCH v2 0/2] Fix two bugs of switchtec module


On 2019-04-15 8:41 a.m., Wesley Sheng wrote:
> Hi, Everyone,
> 
> This patch series fix two bugs of switchtec module.
> 
> The first is introduced by device spec definition issue: the maximum
> supported PCIe function number by hardware should be 255 instead of 
> the false number of 48. Rectify it in driver and for backward 
> compatible, a new ioctl and corresponding data structure are created,
> while keep the deprecated one.
> 
> The second is MRPC event unintentionally masked at corner case.
> Fix this bug by skipping the mask operation for MRPC event in event ISR
> like what we already do for LINK event.
> 
> Regard,
> Wesley
> 
> --
> 
> Changed since v1:
>   - rewrapped the commit message of [PATCH 1/2] into one paragraph

Probably should have collected my Reviewed-by tag into the patches as
well. I still approve this series:

Reviewed-by: Logan Gunthorpe <logang@...tatee.com>

Thanks,

Logan