linux-kernel - Re: [PATCH v2 2/2] perf/x86/intel: force resched when TFA sysctl is modified

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190415155742.GI12232@hirez.programming.kicks-ass.net>
Date:   Mon, 15 Apr 2019 17:57:42 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Stephane Eranian <eranian@...gle.com>
Cc:     linux-kernel@...r.kernel.org, tglx@...utronix.de,
        ak@...ux.intel.com, kan.liang@...el.com, mingo@...e.hu,
        nelson.dsouza@...el.com, jolsa@...hat.com, tonyj@...e.com
Subject: Re: [PATCH v2 2/2] perf/x86/intel: force resched when TFA sysctl is
 modified

On Mon, Apr 08, 2019 at 10:32:52AM -0700, Stephane Eranian wrote:
> +static ssize_t set_sysctl_tfa(struct device *cdev,
> +			      struct device_attribute *attr,
> +			      const char *buf, size_t count)
> +{
> +	bool val;
> +	ssize_t ret;
> +
> +	ret = kstrtobool(buf, &val);
> +	if (ret)
> +		return ret;
> +
> +	/* no change */
> +	if (val == allow_tsx_force_abort)
> +		return count;
> +
> +	allow_tsx_force_abort = val;
> +
> +	get_online_cpus();
> +	on_each_cpu(update_tfa_sched, NULL, 1);
> +	put_online_cpus();
> +
> +	return count;
> +}

So we care about concurrent writing to that file?