lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <2236FBA76BA1254E88B949DDB74E612BA4C4F65E@IRSMSX102.ger.corp.intel.com> Date: Mon, 15 Apr 2019 06:31:03 +0000 From: "Reshetova, Elena" <elena.reshetova@...el.com> To: Julia Lawall <julia.lawall@...6.fr>, "Jan Alexander Steffens (heftig)" <jan.steffens@...il.com> CC: "James E.J. Bottomley" <jejb@...ux.ibm.com>, "Martin K. Petersen" <martin.petersen@...cle.com>, "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "kbuild-all@...org" <kbuild-all@...org> Subject: RE: [PATCH] ZEN: fix platform_no_drv_owner.cocci warnings > From: kbuild test robot <lkp@...el.com> > > Remove .owner field if calls are used which set it automatically > > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci > > Fixes: 26e2aa63d568 ("ZEN: Add VHBA driver") > Signed-off-by: kbuild test robot <lkp@...el.com> > Signed-off-by: Julia Lawall <julia.lawall@...6.fr> > > --- > > There was also a report about: > > drivers/scsi/vhba/vhba.c:184:8-27: atomic_dec_and_test variation before > object free at line 185. > > that Elena may want to comment on. > > Yes, on a quick look it seems that you should be using refcount_t type and not atomic_t for your reference counter, as you use it as classical refcounter, i.e. free the object upon reaching zero, etc: static void vhba_device_put (struct vhba_device *vdev) { if (atomic_dec_and_test(&vdev->refcnt)) { kfree(vdev); } } Any reason why you didn't use refcount_t type to begin with? Best Regards, Elena.
Powered by blists - more mailing lists